Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SingleProject - Commerce #644

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

vatsashah45
Copy link
Contributor

No description provided.

@vatsashah45 vatsashah45 self-assigned this Mar 22, 2024
@eriklimakc eriklimakc marked this pull request as draft March 22, 2024 10:50
@eriklimakc
Copy link
Contributor

eriklimakc commented Mar 26, 2024

Sample updated with latest template.

Known issues so far:

  1. WinAppSDK and Android The app uses the file products.json to store the products info. This file lives in the project root directory, but this file is not found by the code when trying to load the products. It only worked for Windows Packaged when I moved the file to Assets. But it didn't work for Android nor Windows Unpackaged.

  2. When running the app on Desktop no window is launched. Nothing really happens.

  3. On WASM the app is launched, but just a black screen is shown.

I know there are more issues related to loading data. I will post them later after I test it more.

reference/Commerce/Commerce/Commerce.csproj Outdated Show resolved Hide resolved
reference/Commerce/Commerce/Commerce.csproj Outdated Show resolved Hide resolved
reference/Commerce/Directory.Build.props Outdated Show resolved Hide resolved
reference/Commerce/Directory.Build.props Outdated Show resolved Hide resolved
reference/Commerce/global.json Outdated Show resolved Hide resolved
@eriklimakc eriklimakc marked this pull request as ready for review April 8, 2024 15:42
@eriklimakc eriklimakc force-pushed the dev/vs/singleproject-commerce2 branch from b805a1b to 80d7f10 Compare April 17, 2024 18:00
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vatsashah45, @eriklimakc
Few comments:

  • Remove unnecessary files
  • And finally, if you can add a proper ReadMe for the sample please

To have a structure similar to what we have for ToDo here, with a src folder with the source inside, a proper README.md with the details of the sample, and a doc folder for additional documentation or assets needed for the README for example.
image
(cc @LProulx86 as well so we can use the same structure for the others samples)

@eriklimakc
Copy link
Contributor

We're currently facing this issue on this app - unoplatform/uno#16430

@agneszitte
Copy link
Contributor

We're currently facing this issue on this app - unoplatform/uno#16430

@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please?
(cc @nickrandolph)

@eriklimakc
Copy link
Contributor

@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please? (cc @nickrandolph)

Yes, I don't see the build error anymore, so that's fixed. But I see a regression, the Uno.Extensions.Storage.FileStorage issue (https://github.com/unoplatform/uno-private/issues/408) is back only on wasm, and that prevents products from loading:

image

cc @agneszitte @jeromelaban @nickrandolph

@eriklimakc eriklimakc changed the title feat: SIngleProject - Commerce feat: SingleProject - Commerce May 14, 2024
@agneszitte agneszitte changed the base branch from feature/singleproject to master May 17, 2024 17:53
@rajamatt
Copy link
Contributor

With latest packages the warnings for everything related to appsettings still appear on Wasm and other platforms:
image

However, the products.json file does not appear in the warnings. In fact, all the products are loaded and all feeds with products are working as expected.

cc: @agneszitte

@rajamatt
Copy link
Contributor

Favorites

  • All items are favorited by default but they don't appear in the Favorites feed, we have to unfavorite them and favorite them again for them to appear in the Favorites feed.

@rajamatt
Copy link
Contributor

Cart

  • Quantity of items in the cart can't be changed, the "More" and "Less" commands are never bound to in the Xaml
  • Items can't be removed from the cart because the "Remove" command is never bound to in the Xaml

public async ValueTask Remove(CartItem item, CancellationToken ct)
=> await CartService.Remove(item.Product, ct);
public async ValueTask More(CartItem item, CancellationToken ct)
=> await CartService.Update(item.Product, item.Quantity + 1, ct);
public async ValueTask Less(CartItem item, CancellationToken ct)
=> await CartService.Update(item.Product, item.Quantity - 1, ct);

  • Number of items in cart is hardcoded

@rajamatt
Copy link
Contributor

ProductsPage (search page)

  • The "Products found" count is hardcoded

  • Searching for products only works if a filter is selected first
  • Clicking on an item in the Search doesn't do anything (should it?)

@rajamatt
Copy link
Contributor

rajamatt commented May 29, 2024

Miscellaneous

  • About 1/5 of the time, navigating to the profile page causes a COMException (I think its because the profile pictures are random and one of them might be problematic but I'm not sure)

image

  • Back buttons aren't visible but are functional (not sure if it's theming related or not)

image

  • The left hand navbar's items could be spaced a bit better (they are very close together and the focus background stacks on adjacent items)

image

@kazo0
Copy link
Contributor

kazo0 commented Jun 4, 2024

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

@agneszitte
Copy link
Contributor

Related issues:

@rajamatt
Copy link
Contributor

rajamatt commented Jun 5, 2024

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

Done

chore: add vscode folder

chore: add vscode folder
@rajamatt rajamatt force-pushed the dev/vs/singleproject-commerce2 branch from 1adf6fb to 53536b3 Compare June 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants