-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for an out-of-process generation host #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds better support for macOS and adds support for .NET Core builds.
jeromelaban
changed the title
Add support for a out-of-process generation host
Add support for an out-of-process generation host
Oct 12, 2018
jeromelaban
force-pushed
the
dev/jela/oop-generation
branch
from
October 12, 2018 02:15
36dda27
to
8e0490c
Compare
jeromelaban
force-pushed
the
dev/jela/oop-generation
branch
from
October 12, 2018 02:25
8e0490c
to
a18e02e
Compare
- Enable inner binary logger support - Fix inner binary logger file flush - Provide the global errors in the resulting binlog - Add missing binding redirects (XI/XA tasks fails to load) - Remove legacy TargetFrameworkRootPath (the path is already provided by the environment)
jeromelaban
force-pushed
the
dev/jela/oop-generation
branch
from
October 15, 2018 17:05
2016272
to
29f5c55
Compare
carldebilly
reviewed
Oct 15, 2018
@@ -134,11 +134,14 @@ | |||
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | |||
<PropertyGroup> | |||
</PropertyGroup> | |||
<PropertyGroup> | |||
<PostBuildEvent>copy /y "$(TargetDir)\*.*" "\\mm01\Documents\sourcegen-task"</PostBuildEvent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\\mm01
can't be right ;-)
jeromelaban
force-pushed
the
dev/jela/oop-generation
branch
from
October 15, 2018 17:44
b685948
to
7c5b250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better support for macOS and adds support for .NET Core builds.
Fixes #33.