Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS/Android][macOS][CheckBox][Ripple Effect] Ripple Effect does not display correctly if checkbox is tapped multiple times in quick succession #219

Closed
3 of 5 tasks
StewartPolsky opened this issue Jul 13, 2020 · 4 comments
Closed
3 of 5 tasks

[iOS/Android][macOS][CheckBox][Ripple Effect] Ripple Effect does not display correctly if checkbox is tapped multiple times in quick succession #219

StewartPolsky opened this issue Jul 13, 2020 · 4 comments
Assignees
@MaximeDion-Work
Labels
kind/bug Something isn't working

Comments

@StewartPolsky
Copy link
Contributor

StewartPolsky commented Jul 13, 2020 •
edited
Loading

Current behavior

Uno Material Ripple

Expected behavior

Uno Material Ripple wasm

How to reproduce it (as minimally and precisely as possible)

  1. Launch app
  2. Open burger menu
  3. Select CheckBox
  4. Tap a checkbox multiple times in quick succession
  5. Notice that the ripple effect is not displayed correctly

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • MacOS

Anything else we need to know?
@StewartPolsky StewartPolsky added the kind/bug Something isn't working label Jul 13, 2020
@MatFillion
Copy link
Contributor

I don't think there's a ripple control for this one, it's odd.

Was it the issue with VisualTransition you were looking at @MaximeDion-Work ? Is this still happening in your PR #216 ?

@MaximeDion-Work
Copy link
Contributor

Yes it's still happening. It started when the animation were moved from VisualState to VisualState.Transition in commit 65ff3db. I open an issue unoplatform/uno#3532 .

@MatFillion
Copy link
Contributor

@MaximeDion-Work for this one we'll need to look for a work-around, see if we can find an alternative

@StewartPolsky StewartPolsky changed the title [iOS/Android][CheckBox][Ripple Effect] Ripple Effect does not display correctly if checkbox is tapped multiple times in quick succession [iOS/Android][macOS][CheckBox][Ripple Effect] Ripple Effect does not display correctly if checkbox is tapped multiple times in quick succession Jul 23, 2020
@MaximeDion-Work MaximeDion-Work self-assigned this Jul 27, 2020
MaximeDion-Work added a commit that referenced this issue Jul 27, 2020
@MaximeDion-Work
fix: [iOS/Android][macOS][CheckBox][Ripple Effect] Ripple Effect does…
6fc8665 
… not display correctly if checkbox is tapped multiple times in quick succession #219
@StewartPolsky
Copy link
Contributor Author

Issue reproduced on Android and macOS

@StewartPolsky StewartPolsky reopened this Aug 4, 2020
@MaximeDion-Work MaximeDion-Work mentioned this issue Aug 4, 2020
Merged
6 tasks
MaximeDion-Work added a commit that referenced this issue Aug 4, 2020
@MaximeDion-Work
fix: [iOS/Android][macOS][CheckBox][Ripple Effect] Ripple Effect does…
1212e49 
… not display correctly if checkbox is tapped multiple times in quick succession #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximeDion-Work MaximeDion-Work

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MatFillion @StewartPolsky @MaximeDion-Work