Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust splash screen image sizing #707

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Apr 9, 2023

fixes #706

The changes are made to match the styling in Uno.UI

@MartinZikmund MartinZikmund self-assigned this Apr 9, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-river-0087b630f-707.eastus2.1.azurestaticapps.net

@igiona
Copy link

igiona commented Apr 11, 2023

The linked issue happens also with custom splash screens.
Would this fix work for any picture?
The hard-coded pixel definitions:

max-width: min(90%, 620px);
max-height: min(90%, 300px);

make me wonder, but I might be missing something here 😄

@jeromelaban
Copy link
Member

The fixed size is a mirror of the UWP splashscreen specifications. It may not be appropriate in all contexts, though.

@MartinZikmund MartinZikmund linked an issue May 1, 2023 that may be closed by this pull request
8 tasks
@jeromelaban jeromelaban merged commit 4c62621 into main May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/mazi/splash-sizing branch May 8, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splash screen image sizing is not uniform
4 participants