fix(skia): Fix support for UIElementCollection item replace

unoplatform · Dec 16, 2021 · bd22523 · bd22523
1 parent 5716a96
commit bd22523
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/Uno.UI/UI/Xaml/UIElement.skia.cs b/src/Uno.UI/UI/Xaml/UIElement.skia.cs
@@ -158,6 +158,15 @@ internal bool RemoveChild(UIElement child)
 			}
 		}
 
+		internal UIElement ReplaceChild(int index, UIElement child)
+		{
+			var previous = _children[index];
+			RemoveChild(previous);
+			AddChild(child, index);
+
+			return previous;
+		}
+
 		internal void ClearChildren()
 		{
 			foreach (var child in _children.ToArray())

diff --git a/src/Uno.UI/UI/Xaml/UIElementCollection.netstd.cs b/src/Uno.UI/UI/Xaml/UIElementCollection.netstd.cs
@@ -65,8 +65,10 @@ private View RemoveAtCore(int index)
 			return item;
 		}
 
-		private bool RemoveCore(View item) => _owner.RemoveChild(item);
+		private bool RemoveCore(View item)
+			=> _owner.RemoveChild(item);
 
-		private View SetAtIndexCore(int index, View value) => throw new NotImplementedException();
+		private View SetAtIndexCore(int index, View value)
+			=> _owner.ReplaceChild(index, value);
 	}
 }