Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a check that validates Gtk 3 installation on Windows #94

Conversation

aesteves900
Copy link
Collaborator

@aesteves900 aesteves900 commented Sep 5, 2022

GitHub Issue (If applicable): closes #12

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

People from the community have reported that certain projects fail to build because of long paths.

There is no check for GTK3 activation on Windows.

What is the new behavior?

The uno-check will validate the presence of GTK3+ and install if required.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current Figma desktop app
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes and the PlugIn is BACKWARD COMPATIBLE
  • Associated with an issue

Other information

@aesteves900 aesteves900 self-assigned this Sep 5, 2022
@aesteves900 aesteves900 marked this pull request as draft September 6, 2022 01:38
@aesteves900 aesteves900 force-pushed the dev/AEST/12-add-validation-gtk3-windows branch from a794b2f to 15be4e7 Compare September 7, 2022 02:48
@aesteves900 aesteves900 force-pushed the dev/AEST/12-add-validation-gtk3-windows branch 4 times, most recently from 6912621 to 1aa1a2c Compare September 7, 2022 21:11
@aesteves900 aesteves900 marked this pull request as ready for review September 7, 2022 21:25
@aesteves900 aesteves900 force-pushed the dev/AEST/12-add-validation-gtk3-windows branch from 1aa1a2c to 8d79940 Compare September 13, 2022 04:24
UnoCheck/ToolInfo.cs Outdated Show resolved Hide resolved
UnoCheck/Manifest/Gtk.cs Outdated Show resolved Hide resolved
@aesteves900 aesteves900 force-pushed the dev/AEST/12-add-validation-gtk3-windows branch 3 times, most recently from 29615a4 to 3ae3c7a Compare September 14, 2022 01:36
UnoCheck/Checkups/GTKCheckup.cs Outdated Show resolved Hide resolved
UnoCheck/Checkups/GTKCheckup.cs Outdated Show resolved Hide resolved
UnoCheck/Checkups/GTKCheckup.cs Outdated Show resolved Hide resolved
UnoCheck/Manifest/Gtk.cs Outdated Show resolved Hide resolved
UnoCheck/Manifest/Gtk.cs Outdated Show resolved Hide resolved
UnoCheck/Manifest/Gtk.cs Show resolved Hide resolved
UnoCheck/ToolInfo.cs Outdated Show resolved Hide resolved
feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows

feat: Add a check that validates Gtk 3 installation on Windows
@jeromelaban jeromelaban force-pushed the dev/AEST/12-add-validation-gtk3-windows branch from f92ca0f to c700e89 Compare October 18, 2022 12:56
@jeromelaban
Copy link
Member

Deprecated feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a check that validates Gtk 3 installation on Windows
3 participants