Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mvux): Fix misc selection issues #1323

Merged
merged 4 commits into from
Mar 28, 2023
Merged

fix(mvux): Fix misc selection issues #1323

merged 4 commits into from
Mar 28, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Mar 24, 2023

fixes #1233

Bugfix

  • In Single selection mode the ListView.SelectedItem is not updated when it's being updated by the model
  • On Windows the mutli-selection mode is not working properly
  • When multi-select, the selection ranges are not coerced properly

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb self-assigned this Mar 24, 2023
@dr1rrb dr1rrb merged commit d64f0f1 into main Mar 28, 2023
@dr1rrb dr1rrb deleted the dev/dr/selectionTracking branch March 28, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reactive] Selection lost when editing a selected item
2 participants