Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preventing nav on null item selection #1332

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1331

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Navigation is triggered on selection changed even when selected item is null

What is the new behavior?

No navigation when selected item is null

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit 9ff68c9 into main Mar 28, 2023
@nickrandolph nickrandolph deleted the dev/nr/nullnav branch March 28, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants