Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch from SelectedItem to using SelectionChanged args #1345

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Mar 31, 2023

GitHub Issue (If applicable): closes #1344

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Navigation uses SelectedItem

What is the new behavior?

Navigation uses AddedItems in the SelectionChanged handler

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@lukeblevins lukeblevins self-requested a review March 31, 2023 14:30
@nickrandolph nickrandolph merged commit c04dc9c into main Apr 3, 2023
10 of 11 checks passed
@nickrandolph nickrandolph deleted the dev/nr/selecteditem branch April 3, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Navigation.Request on ListView should use args not SelectedItem
3 participants