fix: Correct selection change for when addeditems is null #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
approved these changes
Apr 3, 2023
nickrandolph
force-pushed
the
dev/nr/navselection
branch
from
c85df1c
to
94c6832
Compare
nickrandolph
force-pushed
the
dev/nr/navselection
branch
from
94c6832
to
e0e230b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #1344 #1365
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If AddedItems is empty navigation isn't done, even if SelectedItems has a value
What is the new behavior?
Fallback to SelectedItems if AddedItems is null
Also, prevents multiple handlers so ItemClick is used if IsItemClickEnabled set to true
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):