Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Selecting default culture based on current thread culture #1420

Merged
merged 1 commit into from
May 2, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #1419

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Culture defaults to first in appsettings.json instead of current culture

What is the new behavior?

Current culture used to select default culture from localization config

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit ecef26e into main May 2, 2023
11 of 12 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue1419 branch May 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Localization] Defaults to the first language in list instead of current system language
2 participants