Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(logging): Update for IApplicationBuilder #1451

Merged
merged 7 commits into from
Jun 2, 2023

Conversation

lukeblevins
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@lukeblevins lukeblevins changed the title docs(logging): initial updated doc docs(logging): Update for IApplicationBuilder May 9, 2023
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Show resolved Hide resolved
@lukeblevins
Copy link
Contributor Author

Thanks for the feedback @weitzhandler! I've addressed it with the latest commit

doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
doc/Overview/Logging/LoggingOverview.md Outdated Show resolved Hide resolved
Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
@nickrandolph nickrandolph merged commit 5f17587 into main Jun 2, 2023
5 of 6 checks passed
@nickrandolph nickrandolph deleted the dev/lubl/logging-iab branch June 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants