fix: Preventing crash when app data folder doesn't exist #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
force-pushed
the
dev/nr/issue1494
branch
from
ff5efa3
to
35170bf
Compare
dansiegel
reviewed
May 24, 2023
src/Uno.Extensions.Configuration/ConfigurationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
jeromelaban
reviewed
May 24, 2023
nickrandolph
force-pushed
the
dev/nr/issue1494
branch
4 times, most recently
from
4507166
to
0023444
Compare
nickrandolph
force-pushed
the
dev/nr/issue1494
branch
from
0023444
to
134e369
Compare
dansiegel
approved these changes
May 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #1494
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See #1494
What is the new behavior?
App data folder should be created if doesn't exist
Configuration (settings) isn't loaded if app data folder doesn't exist
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):