Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding null check before calling Update on Bindings #1535

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1534

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Null reference on WinUI in certain cases when calling Update when Bindings is null

What is the new behavior?

Null check prevents calling Update when Bindings is null

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ X ] Tested code with current supported SDKs
  • [ N/A ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [ N/A ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ X ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [ X ] Contains NO breaking changes
  • [ N/A ] Updated the Release Notes
  • [ X ] Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph merged commit 645f1c4 into main Jun 6, 2023
11 of 12 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue1534 branch June 6, 2023 02:12
@nickrandolph
Copy link
Contributor Author

nickrandolph commented Jun 6, 2023

https://github.com/Mergifyio backport release/stable/2.4

GitHub
Automate your pull requests. Mergify has 20 repositories available. Follow their code on GitHub.

@mergify
Copy link

mergify bot commented Jun 6, 2023

backport release/stable/2.4

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Jun 6, 2023
….4/pr-1535

fix: Adding null check before calling Update on Bindings (backport #1535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants