Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update broken URLs on README #1538

Merged
merged 1 commit into from
Jun 13, 2023
Merged

docs: Update broken URLs on README #1538

merged 1 commit into from
Jun 13, 2023

Conversation

lukeblevins
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit 7a34843 into main Jun 13, 2023
5 of 6 checks passed
@nickrandolph nickrandolph deleted the dev/lubl/readme-urls branch June 13, 2023 08:37
@nickrandolph
Copy link
Contributor

@lukeblevins I just realised after I merged this that we should be using xref links instead of hardcoded links. Can you update these links and push a new PR please

@lukeblevins
Copy link
Contributor Author

@nickrandolph Good catch. I've opened #1555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants