Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for Mvux.Overview #1584

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Suggestion for Mvux.Overview #1584

merged 11 commits into from
Jun 21, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

  • Documentation content changes

What is the current behavior?

We have a documentation for MVUX

What is the new behavior?

Now we have a different perspective of the current version, to show how MVUX works.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@rafael-rosa-knowcode
Copy link
Contributor Author

rafael-rosa-knowcode commented Jun 19, 2023 •
edited

@nickrandolph
Does this syntax work? [How to create a feed](xref:Overview.Mvux.HowToSimpleFeed)
Another suggestion would be to put more links to other items (Feeds, States, Tutorials)

@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

lukeblevins
lukeblevins requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! I mostly had some rephrasing suggestions, but keep in mind these impressions are from someone entirely new to MVUX.

doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/Overview.md Outdated Show resolved Hide resolved
rafael-rosa-knowcode and others added 3 commits June 20, 2023 09:52
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe
23638f7 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe of xref
1760dcf 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe UX
b040311 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe
2aafc9f 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

rafael-rosa-knowcode and others added 3 commits June 20, 2023 09:59
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe
35d4f93 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe
0e907e5 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@rafael-rosa-knowcode @lukeblevins
refactor: update sintaxe
ea76f25 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

3 similar comments
@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@nickrandolph @lukeblevins
doc: Tweak intro text
275c974 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@nickrandolph @lukeblevins @weitzhandler
docs: Suggestions
ac33326 
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
Co-authored-by: Shimmy <2716316+weitzhandler@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@nickrandolph
Copy link
Contributor

I've pushed changes to this PR and am going to merge it as is - there's further work to be done on this document, so I'm not going to be too picky at this point

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited by unfurl-links bot

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1584.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit d64a88a into main Jun 21, 2023
6 checks passed
@nickrandolph nickrandolph deleted the dev/ramr/docsMVUXoverview branch June 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrandolph nickrandolph nickrandolph approved these changes

@lukeblevins lukeblevins lukeblevins approved these changes

@weitzhandler weitzhandler Awaiting requested review from weitzhandler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafael-rosa-knowcode @nickrandolph @weitzhandler @lukeblevins