Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for custom endpointoptions #1591

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes: #1590

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Additional settings for httpclient need to be done through a custom appsettings section

What is the new behavior?

Additional settings for httpclient can be added to existing endpoint section using a sub-class of EndpointOptions to access the information in code

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X ] Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph marked this pull request as draft June 22, 2023 04:21
@nickrandolph
Copy link
Contributor Author

@lukeblevins can you update the http + refit documentation to include this feature. Take a look at the usage in the TestHarness sample for http and refit for an example of how to use this

.gitignore Show resolved Hide resolved
@nickrandolph nickrandolph marked this pull request as ready for review July 17, 2023 07:10
@lukeblevins
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lukeblevins lukeblevins merged commit 2eab66a into main Jul 17, 2023
13 of 15 checks passed
@lukeblevins lukeblevins deleted the dev/nr/issue1590 branch July 17, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Http/Refit] Add support for custom EndpointOptions to customize endpoint configuration
2 participants