Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensuring navigators get corrected once region hierarchy loaded #1608

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jun 30, 2023

GitHub Issue (If applicable): #1607

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The navigator for nested regions isn't being created

What is the new behavior?

Once the region hierarchy has been created, all navigators are now loaded

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [N/A] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [N/A] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • [N/A] Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit c858f37 into main Jul 3, 2023
10 of 11 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue1607 branch July 3, 2023 05:38
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 3, 2023

backport legacy/2x

✅ Backports have been created

@nickrandolph
Copy link
Contributor Author

@Mergifyio backport release/stable/2.4

@mergify
Copy link

mergify bot commented Jul 3, 2023

backport release/stable/2.4

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Jul 3, 2023
fix: Ensuring navigators get corrected once region hierarchy loaded (backport #1608)
nickrandolph added a commit that referenced this pull request Jul 3, 2023
….4/pr-1608

fix: Ensuring navigators get corrected once region hierarchy loaded (backport #1608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants