Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce the amount of GetSymbolInfo calls for PropertySelectorGenerator #1626

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 7, 2023

GitHub Issue (If applicable): closes #1625

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 requested a review from dr1rrb July 7, 2023 08:11
Copy link
Member

@dr1rrb dr1rrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the condition of the analyzer?

Co-authored-by: David <github.site@torick.net>
@Youssef1313
Copy link
Member Author

Should we also update the condition of the analyzer?

I guess not, unless I'm missing something. There are two cases:

  • Case 1: There is no SimpleLambdaExpressionSyntax argument -> Reported here by the analyzer already.
  • Case 2: There is SimpleLambdaExpressionSyntax with missing tokens -> The compiler will be reporting compile errors.

@Youssef1313 Youssef1313 merged commit b0894df into unoplatform:main Jul 10, 2023
10 of 11 checks passed
@Youssef1313 Youssef1313 deleted the property-selector-perf branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropertySelectorGenerator is very slow
3 participants