Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Questions.md #1628

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update Questions.md #1628

merged 1 commit into from
Jul 10, 2023

Conversation

jguadagno
Copy link
Contributor

Fixed multiple spelling errors of Extensions

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?

The word extension was spelled incorrectly multiple times on the page

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please update the commit message to use conventional commits?

The conventional commits check isn't currently running in CI by mistake, which I'm fixing in #1629.

Fixed multiple spelling errors of Extensions

Co-Authored-By: Joseph Guadagno <jguadagno@hotmail.com>
@lukeblevins
Copy link
Contributor

@jguadagno Thank you for spotting this!

@lukeblevins lukeblevins merged commit 8afa613 into unoplatform:main Jul 10, 2023
6 of 7 checks passed
@welcome
Copy link

welcome bot commented Jul 10, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants