Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing Uno.Extensions.Toolkit as uno.toolkit no longer referenced #1640

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jul 10, 2023

GitHub Issue (If applicable): #1627

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Uno.Extensions.Toolkit/Toolkit.UI/Toolkit.WinUI is confusing since the packages no longer require uno.toolkit

What is the new behavior?

Code is moved to Uno.Extensions.Core/Core.UI/Core.WinUI
HostBuilderExtensions moved to Uno.Extensions.Hosting.UI/WinUI

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [N/A] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [N/A] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [N/A] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review July 11, 2023 08:32
@nickrandolph
Copy link
Contributor Author

@lukeblevins can we add to v5 migration documentation:

  • Remove Uno.Extensions.Toolkit and Uno.Extensions.Toolkit.UI/WinUI package references (no longer required)
  • Remove Uno.Extensions package reference (no longer required)

@nickrandolph nickrandolph merged commit 27a3afd into main Jul 11, 2023
11 of 12 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue1627 branch July 11, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants