Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Disable XAML fuzzy matching #1677

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor

@Youssef1313 why is this required?

@jeromelaban
Copy link
Member

jeromelaban commented Jul 21, 2023

@Youssef1313 why is this required?

The option was meant to false by default when Uno 5 dev was originally published, but we forgot about it. This change is about validating that disabling fuzzy matching is not breaking anything here.

@nickrandolph nickrandolph merged commit 453ba26 into unoplatform:main Jul 26, 2023
11 of 12 checks passed
@Youssef1313 Youssef1313 deleted the disable-fuzzy branch July 26, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants