Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added INavigator to both NavigationResponse as well as IRouteNotifier #1678

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1675

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Hard using either IRouteNotifier or NavigationResponse to access the INavigator of the newly created view. Particulalry useful for dialogs where having a reference to the INavigator allows it to be closed.

What is the new behavior?

IRouteNotifier RouteChangedEventArgs now includes INavigator that represents where the view changed. NavigationResponse also has a reference to the INavigator that changed the route.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor Author

@lukeblevins can we create an advanced topic that looks at using the IRouteNotifier and the NavigationResponse to access the INavigator. An example where this would be useful is opening a dialog where you might want to cancel the dialog via the INavigator instance

@nickrandolph nickrandolph merged commit 9bf0bf6 into main Jul 26, 2023
11 of 12 checks passed
@nickrandolph nickrandolph deleted the dev/nr/issue1675 branch July 26, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants