test(mvux): Ensure that feed parameters shares the same context as the Model #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr1rrb
force-pushed
the
dev/dr/vmCommands
branch
from
f4fd89f
to
9bed523
Compare
|
@mergify backport legacy/2x |
✅ Backports have been created
|
dr1rrb
added a commit
that referenced
this pull request
Aug 15, 2023
test(mvux): Ensure that feed parameters shares the same context as the Model (backport #1695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1622
Tests
Ensure that feed parameters shares the same context as the Model
What is the current behavior?
In old versions of reactive it might happen that context used for command's "feed parameters" was not the same as the model itself.
What is the new behavior?
Add tests to enforce no regression
PR Checklist
Screenshots Compare Test Runresults.