Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump WinAppSdk reference version #1752

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): N/A (canary build error)

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Toolkit has incremented WinAppSdk to v1.1.5 which results in a break due to version mismatch

What is the new behavior?

Minimum WinAppSdk dependency ix 1.1.5

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [N/A] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • [N/A] Updated the Release Notes
  • [N/A] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/incrementwinappsdk branch 2 times, most recently from 21edf4b to e9908ec Compare August 10, 2023 15:48
@nickrandolph nickrandolph merged commit a7f5894 into main Aug 11, 2023
11 of 12 checks passed
@nickrandolph nickrandolph deleted the dev/nr/incrementwinappsdk branch August 11, 2023 05:58
@nickrandolph
Copy link
Contributor Author

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 14, 2023

backport legacy/2x

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Aug 14, 2023
fix: Bump WinAppSdk reference version (backport #1752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants