fix: Disable maui initializers on windows #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
force-pushed
the
dev/nr/winuistyles
branch
from
b41cfa4
to
ae1f074
Compare
nickrandolph
force-pushed
the
dev/nr/winuistyles
branch
from
ae1f074
to
c63db82
Compare
dansiegel
approved these changes
Aug 10, 2023
|
@mergify backport legacy/2x |
✅ Backports have been created
|
nickrandolph
added a commit
that referenced
this pull request
Aug 14, 2023
fix: Disable maui initializers on windows (backport #1754)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #https://github.com/unoplatform/uno.extensions-private/issues/105
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Material styles don't show in WinUI target for Uno app when UseMauiEmbedded is called
What is the new behavior?
Maui initializers are removed so the Material resources are available in Uno app (Windows)
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):