Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FeedView not initializing properly if not visible on first load #1756

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Aug 10, 2023

closes #1666

Bugfix

FeedView not initializing properly is not visible on first load

What is the current behavior?

FeedView subscribes to its Source on loaded, no matter if the template has yet been applied or not. This drives the FeedView to invoke some GoToState which does nothing, and will not do it again when template is being applied.

What is the new behavior?

We wait to have both being loaded and have a template applied before subscribing to the Source.

Note: This also make sure to not load some data if useless, which is the expected default behavior so far.

PR Checklist

  • [ x Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge August 10, 2023 21:15
@dr1rrb dr1rrb merged commit 08d3b2b into main Aug 11, 2023
11 of 12 checks passed
@dr1rrb dr1rrb deleted the dev/dr/feeViewVisiInit branch August 11, 2023 08:52
@dr1rrb dr1rrb changed the title fix: FeedView not initializing properly is not visible on first load fix: FeedView not initializing properly if not visible on first load Aug 11, 2023
@dr1rrb
Copy link
Member Author

dr1rrb commented Aug 14, 2023

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 14, 2023

backport legacy/2x

✅ Backports have been created

dr1rrb added a commit that referenced this pull request Aug 15, 2023
fix: FeedView not initializing properly if not visible on first load (backport #1756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows][Regions][FeedViews] FeedView remains collapsed when using Region navigation
2 participants