Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Adjust generator packaging to not require double build #1762

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 14, 2023

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

DownloadAndSetPackageIcon can be run twice for the same project.

image

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit d6e9df8 into unoplatform:main Aug 14, 2023
11 of 12 checks passed
@nickrandolph
Copy link
Contributor

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 14, 2023

backport legacy/2x

✅ Backports have been created

@Youssef1313 Youssef1313 deleted the fix-build branch August 14, 2023 08:32
nickrandolph added a commit that referenced this pull request Aug 14, 2023
build: Adjust generator packaging to not require double build (backport #1762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants