Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Getting Started instructions for .NET MAUI #1783

Merged
merged 15 commits into from
Sep 6, 2023
Merged

feat: Adding Getting Started instructions for .NET MAUI #1783

merged 15 commits into from
Sep 6, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Aug 15, 2023 •
edited

closes: https://github.com/unoplatform/uno.extensions-private/issues/124

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

Outdated getting started docs for .NET MAUI
No docs for using GrapeCity controls

What is the new behavior?

Updated Getting Started docs for .NET MAUI
Instructions for using GrapeCity FlexGrid and Calendar

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as draft August 15, 2023 12:18
nickrandolph and others added 5 commits September 1, 2023 18:42
@nickrandolph
feat: Adding instructions for GrapeCity
bcc0c80
@nickrandolph
docs: Linking controls docs
6249fbf
@nickrandolph @Youssef1313
chore: tidyup
82dad63 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@nickrandolph @Youssef1313
chore: Tidyup
fff6bf0 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@nickrandolph @Youssef1313
chore: tidyup
28ec633 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@nickrandolph nickrandolph force-pushed the dev/nr/mauidocs branch 2 times, most recently from 30adafc to b4d8ae9 Compare September 1, 2023 08:44
@nickrandolph nickrandolph marked this pull request as ready for review September 6, 2023 08:55
@nickrandolph nickrandolph changed the title feat: Adding instructions for GrapeCity feat: Adding Getting Started instructions for .NET MAUI Sep 6, 2023
nickrandolph and others added 6 commits September 6, 2023 19:20
@nickrandolph @Youssef1313
chore: tidyup
64b7484 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@nickrandolph @Youssef1313
chore: tidyup
7ae0e68 
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
@nickrandolph
chore: Formatting
c3623d2
@nickrandolph
Merge branch 'dev/nr/mauidocs' of https://github.com/unoplatform/uno.…
b83ebf8 
…extensions into dev/nr/mauidocs
@nickrandolph
chore: Correction
37e6dc3
@nickrandolph
chore: Correct indentation
e49ea9d
Youssef1313
Youssef1313 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I haven't followed the instructions, just reading through the PR.

@nickrandolph nickrandolph merged commit 4f2d898 into main Sep 6, 2023
6 of 7 checks passed
@nickrandolph nickrandolph deleted the dev/nr/mauidocs branch September 6, 2023 09:30
@agneszitte agneszitte linked an issue Sep 11, 2023 that may be closed by this pull request
[Maui Embedding] Related documentation for Uno.Extensions and Uno.Samples #1877
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maui Embedding] Related documentation for Uno.Extensions and Uno.Samples
2 participants
@nickrandolph @Youssef1313