set the page after initializing the Handler #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
approved these changes
Aug 25, 2023
|
@mergify backport legacy/2x |
✅ Backports have been created
|
|
@mergify backport release/stable/2.5 |
✅ Backports have been created
|
nickrandolph
added a commit
that referenced
this pull request
Aug 30, 2023
set the page after initializing the Handler (backport #1813)
nickrandolph
added a commit
that referenced
this pull request
Aug 30, 2023
….5/pr-1813 set the page after initializing the Handler (backport #1813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We set the page in the window constructor... this can generate an exception where the Window Handler is not yet initialized.
What is the new behavior?
Set the Page on the Window after the Window Handler is set.