Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setting Activity in Android context #1829

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Android context not being correctly set on MauiContext causing issues with alertmanager

What is the new behavior?

Android context correctly set

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/windowasparent branch 2 times, most recently from 659cab8 to 5a31a86 Compare August 29, 2023 07:45
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small question

@nickrandolph nickrandolph merged commit 96d48ed into main Aug 29, 2023
12 of 13 checks passed
@nickrandolph nickrandolph deleted the dev/nr/windowasparent branch August 29, 2023 09:31
@nickrandolph
Copy link
Contributor Author

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 29, 2023

backport legacy/2x

✅ Backports have been created

@nickrandolph
Copy link
Contributor Author

@mergify backport release/stable/2.5

@mergify
Copy link

mergify bot commented Aug 29, 2023

backport release/stable/2.5

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Aug 29, 2023
fix: Setting Activity in Android context (backport #1829)
nickrandolph added a commit that referenced this pull request Aug 29, 2023
….5/pr-1829

fix: Setting Activity in Android context (backport #1829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants