Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding UIWindow to the service container #1832

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

UIWindow isn't accessible

What is the new behavior?

UIWindow is added to the maui context service container

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/imageconverter branch 2 times, most recently from ea021b3 to dc707d8 Compare August 29, 2023 14:58
@nickrandolph nickrandolph merged commit 61cbe29 into main Aug 29, 2023
12 of 13 checks passed
@nickrandolph nickrandolph deleted the dev/nr/imageconverter branch August 29, 2023 15:37
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@nickrandolph
Copy link
Contributor Author

@Mergifyio backport release/stable/2.5

@mergify
Copy link

mergify bot commented Aug 29, 2023

backport legacy/2x

✅ Backports have been created

@mergify
Copy link

mergify bot commented Aug 29, 2023

backport release/stable/2.5

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Aug 29, 2023
fix: Adding UIWindow to the service container (backport #1832)
jeromelaban added a commit that referenced this pull request Aug 29, 2023
….5/pr-1832

fix: Adding UIWindow to the service container (backport #1832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants