chore: tidy up UseMauiEmbedding extension methods #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
approved these changes
Aug 31, 2023
nickrandolph
force-pushed
the
dev/nr/mauidi
branch
from
01188bf
to
b1dd250
Compare
nickrandolph
force-pushed
the
dev/nr/mauidi
branch
from
b1dd250
to
a17b1bb
Compare
|
@mergify backport legacy/2x |
✅ Backports have been created
|
|
@mergify backport release/stable/2.5 |
✅ Backports have been created
|
nickrandolph
changed the title
This was referenced Aug 31, 2023
jeromelaban
added a commit
that referenced
this pull request
Aug 31, 2023
chore: tidy up UseMauiEmbedding extension methods (backport #1838)
jeromelaban
added a commit
that referenced
this pull request
Aug 31, 2023
….5/pr-1838 chore: tidy up UseMauiEmbedding extension methods (backport #1838)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Multiple overloads for UseMauiEmbedding that aren't required
What is the new behavior?
Only three overloads that extend IAppBuilder, IhostBuilder and Application
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):