Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hot Reload throwing exception #1839

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: Hot Reload throwing exception #1839

merged 2 commits into from
Aug 31, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): https://github.com/unoplatform/uno.extensions-private/issues/59

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Hot Reload causes maui embedding app to crash

What is the new behavior?

No crashes when hot reload is enabled

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor Author

@mergify backport legacy/2x

@nickrandolph
Copy link
Contributor Author

@mergify backport release/stable/2.5

@mergify
Copy link

mergify bot commented Aug 31, 2023

backport legacy/2x

✅ Backports have been created

@mergify
Copy link

mergify bot commented Aug 31, 2023

backport release/stable/2.5

✅ Backports have been created

@nickrandolph nickrandolph merged commit 2d5a304 into main Aug 31, 2023
12 of 13 checks passed
@nickrandolph nickrandolph deleted the dev/nr/hotreloadfix branch August 31, 2023 16:24
jeromelaban added a commit that referenced this pull request Aug 31, 2023
….5/pr-1839

fix: Hot Reload throwing exception (backport #1839)
nickrandolph added a commit that referenced this pull request Sep 1, 2023
fix: Hot Reload throwing exception (backport #1839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants