Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating WebAuthbrowser to latest form winuiex #1891

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Sep 18, 2023

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

WinUIEx WebAuthenticator is out of date
Oidc provider creates instance of WebBrowser

What is the new behavior?

WebAuthenticator updated with latest code from WinUIExe
Oidc provider has IBrowser injected

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review September 18, 2023 15:45
@nickrandolph nickrandolph force-pushed the dev/nr/registerwebbrowser branch 4 times, most recently from 816d27c to b901dd1 Compare November 14, 2023 14:15
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1891.eastus2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1891.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit 52b8469 into main Nov 22, 2023
15 checks passed
@nickrandolph nickrandolph deleted the dev/nr/registerwebbrowser branch November 22, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants