Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Navigation to implicit route clears backstack #2031

Merged
merged 8 commits into from
Nov 14, 2023
Merged

fix: Navigation to implicit route clears backstack #2031

merged 8 commits into from
Nov 14, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Nov 13, 2023 •
edited

GitHub Issue (If applicable): closes #2032

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Implicit routes don't work with mvux
Navigating to implicit route clears frame backstack

What is the new behavior?

Implicit routes work with mvux and navigating to an implicit route doesn't clear backstack

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@nickrandolph nickrandolph changed the title Dev/nr/implicitnav fix: Navigation to implicit route clears backstack Nov 13, 2023
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@nickrandolph nickrandolph marked this pull request as ready for review November 13, 2023 17:26
@nickrandolph @dansiegel
chore: tidy up
56125f5 
Co-authored-by: Dan Siegel <me@dansiegel.net>
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-2031.eastus2.azurestaticapps.net

@dansiegel dansiegel merged commit 79444f7 into main Nov 14, 2023
15 checks passed
@dansiegel dansiegel deleted the dev/nr/implicitnav branch November 14, 2023 08:06
@nickrandolph
Copy link
Contributor Author

@mergify backport release/stable/3.0

@mergify Mergify
Copy link

mergify bot commented Nov 14, 2023 •
edited

backport release/stable/3.0

❌ No backport have been created

  • Backport to branch release/stable/3.0 failed

Git reported the following error:

error: commit 569291aa23e8f0de18b6a7c95588f1e4104bc613 is a merge but no -m option was given.
fatal: cherry-pick failed

@nickrandolph
Copy link
Contributor Author

cc @jeromelaban see above Mergify fail - I guess I'll have to manually backport this?

@nickrandolph nickrandolph mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigating to implciit route clears backstack
2 participants
@nickrandolph @dansiegel