Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Uniformize public async API #2068

Merged
merged 4 commits into from
Nov 27, 2023
Merged

feat: Uniformize public async API #2068

merged 4 commits into from
Nov 27, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 24, 2023

Feature

Uniformize public async API

What is the current behavior?

  • Rely only on IDE for async handling
  • Enforce code quality by forcing usage of CancellationToken

What is the new behavior?

  • Suffix all method with Async
  • Make CancellationToken optional

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb merged commit c52ab0b into main Nov 27, 2023
14 of 15 checks passed
@dr1rrb dr1rrb deleted the dev/dr/asyncCT branch November 27, 2023 21:44
nickrandolph pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants