Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update runtime-test engine #2083

Merged
merged 2 commits into from
Dec 5, 2023
Merged

test: Update runtime-test engine #2083

merged 2 commits into from
Dec 5, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 30, 2023

Other

Update runtime-test engine

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@nickrandolph
Copy link
Contributor

@dr1rrb I've approved this but it would be good to update the CI to actually run the Runtimetests, which I don't think is being done at the moment

@dr1rrb dr1rrb disabled auto-merge December 1, 2023 14:56
@dr1rrb dr1rrb marked this pull request as draft December 1, 2023 14:57
@dr1rrb
Copy link
Member Author

dr1rrb commented Dec 1, 2023

@dr1rrb I've approved this but it would be good to update the CI to actually run the Runtimetests, which I don't think is being done at the moment

@nickrandolph Good point, and as it's pretty easy now with the latest version of runtime test, I converted this PR as draft and will fix that.

@dr1rrb dr1rrb marked this pull request as ready for review December 4, 2023 19:11
@dr1rrb dr1rrb force-pushed the dev/dr/runtimeTestsUpdate branch 2 times, most recently from f0a78bd to 8e5c3b8 Compare December 5, 2023 03:51
@dr1rrb dr1rrb merged commit d5a18e8 into main Dec 5, 2023
15 of 16 checks passed
@dr1rrb dr1rrb deleted the dev/dr/runtimeTestsUpdate branch December 5, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants