Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Using parameters when navigating back #2101

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): adds to #2097

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When navigating back using native frame, any parameters on the entry in back stack is ignored

What is the new behavior?

The parameter on the backstack entry is used if not navigating back with data

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel merged commit 546f62a into main Dec 8, 2023
15 of 16 checks passed
@dansiegel dansiegel deleted the dev/nr/fixingbacknav branch December 8, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants