Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WinAppSdk workaround with Uno.Sdk #2214

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): closes #

  • n/a

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Workaround conflicts with Uno.Sdk

What is the new behavior?

Workaround is disabled with Uno.Sdk

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel force-pushed the dev/ds/disable-workaround-with-sdk branch from 164296f to d76c5b0 Compare March 22, 2024 17:45
@dansiegel dansiegel force-pushed the dev/ds/disable-workaround-with-sdk branch from d76c5b0 to b44aaf1 Compare March 22, 2024 19:42
@dansiegel dansiegel merged commit 83f4510 into main Mar 22, 2024
15 of 16 checks passed
@dansiegel dansiegel deleted the dev/ds/disable-workaround-with-sdk branch March 22, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants