Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResourceLoaderStringLocalizer not resolving #2302

Merged
merged 1 commit into from
May 24, 2024

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue (If applicable): closes unoplatform/uno#16627

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

IStringLocalizer not resolving on non-windows platforms

What is the new behavior?

^ fixed

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

image
the null-coalesce is working poorly on these two

@nickrandolph nickrandolph merged commit 8ba897a into main May 24, 2024
15 of 16 checks passed
@nickrandolph nickrandolph deleted the dev/xygu/20240524/localizer-not-resolving branch May 24, 2024 16:45
@agneszitte
Copy link
Contributor

@nickrandolph, @Xiaoy312 I think this change should be backported no?

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented May 27, 2024

backport release/stable/4.1

✅ Backports have been created

jeromelaban added a commit that referenced this pull request May 27, 2024
….1/pr-2302

fix: ResourceLoaderStringLocalizer not resolving (backport #2302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Localizer does not work with Desktop/Skia
4 participants