fix: Correcting language override to use full culture name and added Localization page to TestHarness #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Localization page to TestHarness
agneszitte
reviewed
Sep 13, 2022
nickrandolph
force-pushed
the
dev/nr/localizationtesting
branch
from
168d323
to
55e9c3b
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-725.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-725.eastus2.azurestaticapps.net |
nickrandolph
force-pushed
the
dev/nr/localizationtesting
branch
from
811e928
to
e502759
Compare
nickrandolph
force-pushed
the
dev/nr/localizationtesting
branch
from
e502759
to
bd20f7a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-725.eastus2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-725.eastus2.azurestaticapps.net |
jeromelaban
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #721
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Two character language code used instead of Culture name
PrimaryLanguageOverride set too late in app startup sequence
What is the new behavior?
Added a new page to the TestHarness for Localization
PrimaryLanguageOverride is set in a service initialization method immediately after the IHost has been created
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):