Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent Cleared event being raised when there aren't any tokens #746

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #745

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

ITokenCache.Cleared event being raised even when there's no tokens in the cache

What is the new behavior?

Cleared event is only raised when there are existing tokens in the cache that are being cleared

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit d1f8bc2 into main Sep 21, 2022
@nickrandolph nickrandolph deleted the dev/nr/logoutevent branch September 21, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants