fix: Avoiding exceptions loading files on android, ios and winui #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
changed the title
francoistanguay
approved these changes
Sep 26, 2022
nickrandolph
force-pushed
the
dev/nr/filenotfound
branch
from
3da09f6
to
3886c41
Compare
nickrandolph
force-pushed
the
dev/nr/filenotfound
branch
from
3886c41
to
b66aa7e
Compare
jeromelaban
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #753
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Attempting to open a package file using IStorageFile.ReadPackageFileAsync raises an internal exception if the file doesn't exist - particularly bad on startup when application looks for files that need to contribute to configuration
What is the new behavior?
File exists check is made for each platform before attempting to open the file
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):