fix(feeds): Avoid boxing in CollectionAnalyzer #757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Avoid boxing in CollectionAnalyzer
What is the current behavior?
Diff analyzer is working with
object?
which will boxValueType
and requires us to have a specific path for them. Doing this we are also loosing the nullable annotions and prevents us to add helpers for tracking inListFeed<T>
What is the new behavior?
We are using generic everywhere and using
object?
asT
when we don't have type like forCollectionChangedEventArgs
.PR Checklist
Screenshots Compare Test Run
results.