Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feeds): Avoid boxing in CollectionAnalyzer #757

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Sep 23, 2022

Bugfix

Avoid boxing in CollectionAnalyzer

What is the current behavior?

Diff analyzer is working with object? which will box ValueType and requires us to have a specific path for them. Doing this we are also loosing the nullable annotions and prevents us to add helpers for tracking in ListFeed<T>

What is the new behavior?

We are using generic everywhere and using object? as T when we don't have type like for CollectionChangedEventArgs.

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb merged commit 9aaf1b8 into main Sep 23, 2022
@dr1rrb dr1rrb deleted the dev/dr/genericDiffAnalyzer branch September 23, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants