feat: Adding LoadingView support for initial navigation #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
10 times, most recently
from
cd9b5ef
to
138a904
Compare
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
3 times, most recently
from
6a5d482
to
d51caf0
Compare
auto-merge was automatically disabled
October 4, 2022 04:18
Pull request was closed
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
d51caf0
to
d4b8546
Compare
Base automatically changed from
dev/nr/refactortestharness
to
dev/nr/updatingtoolkit
October 5, 2022 02:20
Base automatically changed from
dev/nr/updatingtoolkit
to
dev/nr/playgroundsingleproj
October 5, 2022 02:20
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
d5edffd
to
25f0d7a
Compare
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
25f0d7a
to
dec27d3
Compare
nickrandolph
force-pushed
the
dev/nr/playgroundsingleproj
branch
from
37b5b0f
to
babf0a0
Compare
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
2 times, most recently
from
3e77241
to
d00951a
Compare
nickrandolph
force-pushed
the
dev/nr/versionbump
branch
3 times, most recently
from
22ff94f
to
61f1bf4
Compare
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
a967ca1
to
b8dd04e
Compare
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
fb2c4a4
to
c4b4745
Compare
francoistanguay
approved these changes
Oct 19, 2022
nickrandolph
force-pushed
the
dev/nr/loadingview
branch
from
544a92e
to
14c1c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #777
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently there's a lag between native splashscreen and the first page of the application. On some platforms this shows an empty screen which isn't a great user experience
What is the new behavior?
As part of initializing the application a LoadingView or ExtendedSplashScreen can be set as the main content for the Window. This is done by creating a ShellView (a usercontrol with nested LoadingView or ExtendedSplashScreen) and passing the nested element into the InitializeNavigationAsync method.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):