Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve collection analyzer #771

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Improve collection analyzer #771

merged 5 commits into from
Sep 27, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Sep 27, 2022

Refactoring (no functional changes, no api changes)

Use generics in more cases in order to avoid boxing of value types, and add a visitor pattern for collection change set.

What is the current behavior?

  • We are boxing value types, which is causing issues in comparison and with the nullable annotations.
  • Each time we are digging in a collection change set, we are creating multiple NotifyCollectionChangedEventArgs that are throw away right after and we are losing the "Same" (indicates that an item has been kept) as there is no event action for it.

What is the new behavior?

🙃

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb self-assigned this Sep 27, 2022
@dr1rrb dr1rrb merged commit 0bc9052 into main Sep 27, 2022
@dr1rrb dr1rrb deleted the dev/dr/genDiff branch September 27, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants