Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjusting logic for switching views in grid during navigation #820

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #797

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Switching tabs collapses current tab and sets visible new tab, causing a white flicker particularly the first time navigation to a tab

What is the new behavior?

Switching tabs adjusts opacity (currently setting to a fixed value of 0 or 1) to allow new tabs an opportunity to render before they become visible

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Base automatically changed from dev/nr/versionbump to main October 18, 2022 05:30
@nickrandolph nickrandolph merged commit 11dc382 into main Oct 19, 2022
@nickrandolph nickrandolph deleted the dev/nr/tabswitching branch October 19, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants