Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(selection): Add support for selection in Feeds #860

Merged
merged 12 commits into from
Oct 28, 2022
Merged

feat(selection): Add support for selection in Feeds #860

merged 12 commits into from
Oct 28, 2022

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Oct 25, 2022 •
edited

This is based on #834 which needs to be merge first

fixes #712

Feature

Add support for selection in feeds

What is the current behavior?

No native support

What is the new behavior?

🙃

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb changed the title feat(selection): Add support for slection in Feeds feat(selection): Add support for selection in Feeds Oct 25, 2022
@dr1rrb dr1rrb marked this pull request as draft October 25, 2022 13:32
@dr1rrb
chore(feeds): Improve code auto-completion
d1aeeb6 
- Remove generic Data method, typed constrained on IMessageBuilder, as it was suggested even on Feed. Even if does not compile, it's confusing for users.
- Add overloads for ListFeed that accepts concrete ImmutableList as .ToImmutable() returns that type which is not implciitly convertible to the interface (T is not covariant)
@dr1rrb
feat(selection): Add the selection axis
e8d1cbb
@dr1rrb
chore(selection): Adjust the internal UpdateFeed to allow better mana…
f793616 
…gement of updates from users
@dr1rrb
feat(selection): Add the .Selection operator
ff61854
@dr1rrb
feat(selection): Add ability to test selection axis
543098e
@dr1rrb
feat(selection): Make the BindableCollection to push back selection i…
2a5de9b 
…nto its source ListState
@dr1rrb
test(selection): Test the ListFeedSlection operator
16d7c3a
@dr1rrb
fix(feeds): Make sure to not re-wrap states in states
07c553e
@dr1rrb
fix(selection): Fix support of initial selection in BindableCollection
3103de8
@dr1rrb
feat(keyEq): Generate the IKeyed implementation
41712ad
@dr1rrb
test: Add extentions to test Selection
2fdbb10
@dr1rrb dr1rrb marked this pull request as ready for review October 27, 2022 18:26
@dr1rrb dr1rrb mentioned this pull request Oct 28, 2022
Merged
7 tasks
@dr1rrb dr1rrb enabled auto-merge October 28, 2022 15:16
@dr1rrb dr1rrb merged commit c439932 into main Oct 28, 2022
@dr1rrb dr1rrb deleted the dev/dr/selection branch October 28, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reactive] ListState Selection
2 participants
@dr1rrb @carldebilly