feat: Moving navigation to background thread #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
force-pushed
the
dev/nr/vmthread
branch
3 times, most recently
from
7a41d0a
to
132ef1d
Compare
nickrandolph
force-pushed
the
dev/nr/vmthread
branch
from
132ef1d
to
6de6477
Compare
jeromelaban
reviewed
Oct 27, 2022
jeromelaban
reviewed
Oct 27, 2022
jeromelaban
approved these changes
Oct 27, 2022
Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Navigation is carried out on whatever thread it's initiated on, moving to the UI thread as required
What is the new behavior?
Navigation is moved to background thread
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):